Skip to content

Catch agnostic HTTP error types across cloud_foundry_api and swap the test#24280

Open
mwdd146980 wants to merge 1 commit into
mwdd146980/httpx-migration-basefrom
mwdd146980/w1b-cloud-foundry-api
Open

Catch agnostic HTTP error types across cloud_foundry_api and swap the test#24280
mwdd146980 wants to merge 1 commit into
mwdd146980/httpx-migration-basefrom
mwdd146980/w1b-cloud-foundry-api

Conversation

@mwdd146980

@mwdd146980 mwdd146980 commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Widen the HTTP exception handling in cloud_foundry_api to catch the backend-agnostic HTTPError and HTTPStatusError types alongside the existing requests ones, and swap the tests to inject and assert the agnostic types.

Motivation

Part of the httpx migration. The agnostic http_exceptions hierarchy shares no base class with requests.exceptions, so the check must catch both families to keep working once the HTTP backend swaps to httpx. The connect handlers pair RequestException with the agnostic base HTTPError; the status handlers pair requests' HTTPError (aliased to RequestsHTTPError) with the agnostic HTTPStatusError. No observable behavior change under the shipped requests backend.

Verification

Full cloud_foundry_api unit suite passes. Confirmed red-then-green on the scroll_api_pages handlers: with the tests swapped to agnostic types and production left requests-only, the two scroll error tests fail with the agnostic HTTPError escaping the requests-only except; after widening, they pass. The four re-raise sites (discover_api, get_oauth_token) stay green either way and were verified by reading the handlers. ddev test -fs is clean.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@mwdd146980 @claude
Catch agnostic HTTP error types across cloud_foundry_api and swap the…
1fe6f4d 
… test

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@mwdd146980 mwdd146980 added the qa/skip-qa Automatically skip this PR for the next QA label Jun 30, 2026
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Jun 30, 2026 •
edited by datadog-datadog-prod-us1-2 Bot
Loading

Copy link
Copy Markdown
Contributor

Pipelines  Tests  Code Coverage

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 3 Pipeline jobs failed

PR | test / test-minimum-base-package (linux, ubuntu-22.04, cloud_foundry_api, Cloud Foundry API (py3.13), py... / minimum-base-package-Cloud Foundry API (py3.13)-py3.13   View in Datadog   GitHub Actions

Validate repository | Run Validations / Validate   View in Datadog   GitHub Actions

PR | test / check   View in Datadog   GitHub Actions

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 96.12% (+7.99%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1fe6f4d | Docs | Datadog PR Page | Give us feedback!

@mwdd146980 mwdd146980 self-assigned this Jun 30, 2026
@mwdd146980

mwdd146980 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 1, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1fe6f4dc9a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread cloud_foundry_api/datadog_checks/cloud_foundry_api/cloud_foundry_api.py
@mwdd146980 mwdd146980 marked this pull request as ready for review July 1, 2026 00:55
@mwdd146980 mwdd146980 requested a review from a team as a code owner July 1, 2026 00:55
dkirov-dd
dkirov-dd requested changes Jul 1, 2026
View reviewed changes

@dkirov-dd dkirov-dd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved too fast, could you switch the changelog type to fixed or something other than changed?

@dd-octo-sts

dd-octo-sts Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Validation Report

Validation Description Status
dep Verify dependency pins are consistent and Agent-compatible ❌

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (20)
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file ✅
ci Validate CI configuration and code coverage settings ✅
codeowners Validate every integration has a CODEOWNERS entry ✅
config Validate default configuration files against spec.yaml ✅
http Validate integrations use the HTTP wrapper correctly ✅
imports Validate check imports do not use deprecated modules ✅
integration-style Validate check code style conventions ✅
jmx-metrics Validate JMX metrics definition files and config ✅
labeler Validate PR labeler config matches integration directories ✅
legacy-signature Validate no integration uses the legacy Agent check signature ✅
license-headers Validate Python files have proper license headers ✅
licenses Validate third-party license attribution list ✅
metadata Validate metadata.csv metric definitions ✅
models Validate configuration data models match spec.yaml ✅
openmetrics Validate OpenMetrics integrations disable the metric limit ✅
package Validate Python package metadata and naming ✅
qa-label Validate the pull request declares whether it needs QA for the next Agent release ✅
readmes Validate README files have required sections ✅
saved-views Validate saved view JSON file structure and fields ✅
version Validate version consistency between package and changelog ✅

View full run

@mwdd146980

mwdd146980 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@dkirov-dd I'm using .changed because when the feature branch #22676 eventually does merge into master, I was thinking that a major version change will be warranted at that point. Should I still use fixed?

@mwdd146980 mwdd146980 requested a review from dkirov-dd July 1, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@dkirov-dd dkirov-dd Awaiting requested review from dkirov-dd

Assignees

@mwdd146980 mwdd146980

Labels

agent/requested-changes ecosystems/review-requested integration/cloud_foundry_api product/review-requested qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mwdd146980 @dkirov-dd